Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConsensusPubSubWithSubmitKeyExample #520

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds the ConsensusPubSubWithSubmitKeyExample

Related issue(s):

Fixes #519

Notes for reviewer(s):
This PR depends on #516 and #518 , so those PRs should be approved and merged first.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth linked an issue Oct 11, 2023 that may be closed by this pull request
@rwalworth rwalworth self-assigned this Oct 11, 2023
@rwalworth rwalworth requested a review from deyanzz October 11, 2023 15:05
@rwalworth rwalworth modified the milestone: 0.18.0 Oct 11, 2023
@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Oct 11, 2023
# Conflicts:
#	sdk/examples/ValidateChecksumExample.cc
#	sdk/tests/unit/ClientTest.cc
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deyanzz deyanzz merged commit ebb8ab7 into main Oct 13, 2023
2 checks passed
@deyanzz deyanzz deleted the 00519-add-consensuspubsubwithsubmitkeyexample branch October 13, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ConsensusPubSubWithSubmitKeyExample
2 participants